Skip to content

Added stop ship words #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added stop ship words #927

wants to merge 1 commit into from

Conversation

@gaurav-nelson
Copy link
Contributor

Fixes #926

Added following words to terms error and do not use rules.

"Hong Kong"
"Macao, Macau"
"MCP"
"Republic of China"
"R.O.C., ROC"
"Taiwan"

@github-actions
Copy link

github-actions bot commented Apr 2, 2025 •
edited
Loading

🎊 Navigate the preview: https://redhat-documentation-vale-at-red-hat-927.surge.sh 🎊

@aireilly
Copy link
Member

aireilly commented Apr 8, 2025

Looks good, can you fix this error please?

ERROR: 2 in .vale/fixtures/RedHat/TermsErrors/testinvalid.adoc / .vale/styles/RedHat/TermsErrors.yml

aireilly
aireilly reviewed Apr 24, 2025
View reviewed changes
@aireilly
Copy link
Member

Generally LGTM, with the exception of "MCP" which I don't think should be here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aireilly aireilly aireilly left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

waiting-for-contributor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add stop ship words

3 participants

@gaurav-nelson @aireilly @apinnick